16accb6b24
- 264 license table entries with exact download URLs (224/264 resolved) - Complete sources/ directory with all BitBake recipes - Build configuration: tqma6ul-multi-mba6ulx, spaetzle (musl) - Full traceability for Softwarefreigabeantrag - GCC 13.4.0, Linux 6.6.102, U-Boot 2023.04, musl 1.2.4 - License distribution: GPL-2.0 (24), MIT (23), GPL-2.0+ (18), BSD-3 (16)
72 lines
2.4 KiB
Diff
72 lines
2.4 KiB
Diff
From 16a1242d0ffc7f45ed3c595ee7564b5c04287e0b Mon Sep 17 00:00:00 2001
|
|
From: Olivier Fourdan <ofourdan@redhat.com>
|
|
Date: Mon, 20 Jan 2025 16:52:01 +0100
|
|
Subject: [PATCH] sync: Do not let sync objects uninitialized
|
|
|
|
When changing an alarm, the change mask values are evaluated one after
|
|
the other, changing the trigger values as requested and eventually,
|
|
SyncInitTrigger() is called.
|
|
|
|
SyncInitTrigger() will evaluate the XSyncCACounter first and may free
|
|
the existing sync object.
|
|
|
|
Other changes are then evaluated and may trigger an error and an early
|
|
return, not adding the new sync object.
|
|
|
|
This can be used to cause a use after free when the alarm eventually
|
|
triggers.
|
|
|
|
To avoid the issue, delete the existing sync object as late as possible
|
|
only once we are sure that no further error will cause an early exit.
|
|
|
|
CVE-2025-26601, ZDI-CAN-25870
|
|
|
|
This vulnerability was discovered by:
|
|
Jan-Niklas Sohn working with Trend Micro Zero Day Initiative
|
|
|
|
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
|
|
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1828>
|
|
|
|
Upstream-Status: Backport [https://gitlab.freedesktop.org/xorg/xserver/-/commit/16a1242d]
|
|
CVE: CVE-2025-26601
|
|
Signed-off-by: Vijay Anusuri <vanusuri@mvista.com>
|
|
---
|
|
Xext/sync.c | 13 ++++++++-----
|
|
1 file changed, 8 insertions(+), 5 deletions(-)
|
|
|
|
diff --git a/Xext/sync.c b/Xext/sync.c
|
|
index ee0010e657..585cfa6f68 100644
|
|
--- a/Xext/sync.c
|
|
+++ b/Xext/sync.c
|
|
@@ -360,11 +360,6 @@ SyncInitTrigger(ClientPtr client, SyncTrigger * pTrigger, XID syncObject,
|
|
client->errorValue = syncObject;
|
|
return rc;
|
|
}
|
|
- if (pSync != pTrigger->pSync) { /* new counter for trigger */
|
|
- SyncDeleteTriggerFromSyncObject(pTrigger);
|
|
- pTrigger->pSync = pSync;
|
|
- newSyncObject = TRUE;
|
|
- }
|
|
}
|
|
|
|
/* if system counter, ask it what the current value is */
|
|
@@ -432,6 +427,14 @@ SyncInitTrigger(ClientPtr client, SyncTrigger * pTrigger, XID syncObject,
|
|
}
|
|
}
|
|
|
|
+ if (changes & XSyncCACounter) {
|
|
+ if (pSync != pTrigger->pSync) { /* new counter for trigger */
|
|
+ SyncDeleteTriggerFromSyncObject(pTrigger);
|
|
+ pTrigger->pSync = pSync;
|
|
+ newSyncObject = TRUE;
|
|
+ }
|
|
+ }
|
|
+
|
|
/* we wait until we're sure there are no errors before registering
|
|
* a new counter on a trigger
|
|
*/
|
|
--
|
|
GitLab
|
|
|